Skip to content

fix: allow missing types of rule bypasses #2726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 21, 2025
Merged

fix: allow missing types of rule bypasses #2726

merged 3 commits into from
Oct 21, 2025
+101 −13

Conversation

languitar
Copy link
Contributor

This PR attempts to resolve an issue where the provider is not able to create bypass rules that don't use the explicit values set in this provider. The provider itself is out of date. There is no need for the provider to do the check as the API and helps will do the checks for us.

I've taken the liberty to update #2588 with the pending suggestions.

Resolves #2254
Resolves #2588

Before the change?

Users would not be able to make a bypass rule that uses something like a DeployKey

  bypass_actors {
    actor_type  = "DeployKey"
    bypass_mode = "always"
  }

After the change?

Users can make any bypass rule that is accepted by the API

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@morfien101 @languitar
fix: allow missing types of rule bypasses
08f50d6 
Leave it to the API to determine if the values for actor_types are valid
of not. These change over time and we would need to carry a list in code
to verify this. Do not require an actor_id on rule bypasses. Things like
DeployKey do not have an id.

Signed-off-by: Johannes Wienke <[email protected]>
@languitar languitar mentioned this pull request Aug 11, 2025
Closed
2 tasks
@dsdeboer
Copy link

Great work! I'd love it when we can finally add deploy keys too!

@tnm tnm mentioned this pull request Sep 4, 2025
Merged
@kdelorey kdelorey mentioned this pull request Sep 14, 2025
Open
4 tasks
@tiulpin
Copy link

tiulpin commented Sep 15, 2025

closes #2748

@bradpols
Copy link

bradpols commented Oct 15, 2025 •
edited
Loading

Could we get this merged? Maybe @nickfloyd could help or knows someone who could?

@nickfloyd
Copy link
Contributor

I'll be closing #2255 & #2588 in favor of this one.

@nickfloyd nickfloyd mentioned this pull request Oct 21, 2025
Closed
4 tasks
@nickfloyd nickfloyd merged commit 8b2eac9 into integrations:main Oct 21, 2025
3 checks passed
@github-project-automation github-project-automation bot moved this from Backlog to Done in Terraform Provider Oct 21, 2025
@github-project-automation github-project-automation bot moved this from 🆕 Triage to ✅ Done in 🧰 Octokit Active Oct 21, 2025
@kdelorey
Copy link

@nickfloyd any idea when we might see a release containing this fix?

@dsdeboer
Copy link

Loved to see it merged 🚀 when can I use it with a new release? 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickfloyd nickfloyd nickfloyd approved these changes

+1 more reviewer

@dsdeboer dsdeboer dsdeboer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

Terraform Provider
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEAT]: Add DeployKey to bypass_actors in github_organization_ruleset and github_repository_ruleset

7 participants

@languitar @dsdeboer @tiulpin @bradpols @nickfloyd @kdelorey @morfien101